WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
284933
Avoid churning Style::Colors via colorResolvingCurrentColor()
https://bugs.webkit.org/show_bug.cgi?id=284933
Summary
Avoid churning Style::Colors via colorResolvingCurrentColor()
Simon Fraser (smfr)
Reported
2024-12-18 21:25:04 PST
Style::Color can be expensive to create and destroy because of the std::variant overhead. We can avoid having RenderStyle::unresolvedColorForProperty return a copy.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-12-18 21:25:25 PST
<
rdar://problem/141729996
>
Simon Fraser (smfr)
Comment 2
2024-12-18 21:53:18 PST
Pull request:
https://github.com/WebKit/WebKit/pull/38189
EWS
Comment 3
2024-12-19 10:12:45 PST
Committed
288099@main
(89e7ad233911): <
https://commits.webkit.org/288099@main
> Reviewed commits have been landed. Closing PR #38189 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug