RESOLVED FIXED 284924
"unsafe buffer access" warning in third party code stops building Apple ports in EWS 
https://bugs.webkit.org/show_bug.cgi?id=284924
Summary "unsafe buffer access" warning in third party code stops building Apple ports...
Said Abou-Hallawa
Reported 2024-12-18 17:36:27 PST
The Mac build is broken in https://ews-build.webkit.org/#/builders/55/builds/35737 with this error In file included from /Volumes/Data/worker/macOS-Ventura-Release-Build-EWS/build/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource378.cpp:1: In file included from /Volumes/Data/worker/macOS-Ventura-Release-Build-EWS/build/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCLogSink.cpp:27: In file included from /Volumes/Data/worker/macOS-Ventura-Release-Build-EWS/build/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCLogSink.h:36: In file included from /Volumes/Data/worker/macOS-Ventura-Release-Build-EWS/build/WebKitBuild/Release/usr/local/include/webrtc/rtc_base/logging.h:67: In file included from /Volumes/Data/worker/macOS-Ventura-Release-Build-EWS/build/WebKitBuild/Release/usr/local/include/webrtc/rtc_base/strings/string_builder.h:19: /Volumes/Data/worker/macOS-Ventura-Release-Build-EWS/build/WebKitBuild/Release/usr/local/include/webrtc/api/array_view.h:263:18: error: unsafe buffer access [-Werror,-Wunsafe-buffer-usage]
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-12-18 17:37:04 PST
<rdar://problem/141720579>
Said Abou-Hallawa
Comment 2 2024-12-18 17:40:39 PST
Pull request: https://github.com/WebKit/WebKit/pull/38177
EWS
Comment 3 2024-12-18 18:04:43 PST
Committed 288059@main (5b6e3677c781): <https://commits.webkit.org/288059@main> Reviewed commits have been landed. Closing PR #38177 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.