WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
284916
[Tools][GTK][WPE] MVT test suite: integrate run-mvt-tests with webkitpy facilities and support test expectations
https://bugs.webkit.org/show_bug.cgi?id=284916
Summary
[Tools][GTK][WPE] MVT test suite: integrate run-mvt-tests with webkitpy facil...
Carlos Alberto Lopez Perez
Reported
2024-12-18 16:32:13 PST
I have been evaluating the script run-mvt-tests in order to add a new step to the tests bots and run it. However I found several issues with it that I would like to fix before adding the step: - It does not support running with the system libraries (only flatpak) and the JHBuild support is broken, it is not working for me. This is a requirement for running it on the downstream CI and also for the upcoming Flatpak SDK - It is manually defining environment variables like WEBKIT_EXEC_PATH or WEBKIT_INJECTED_BUNDLE_PATH instead of relying on webkitpy for that. - It does not support WebKitGTK (not a goal, but seems a nice perk to compare results between ports) - It does not support running with the WPE MiniBrowser instead of Cog - It does not support running the complete MVT tests in a round (all the test suites). You have to manually specify which test-suite of MVT you want to run - It does not support test expectations. So it is not useful to run on the bots as it is because it will be failing always if we don't have the ability to mark expected failures - The logging it does is a bit confusing. It is not clear exactly which tests are failing because it prints the verbose log rather than the name of the tests that fail.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2024-12-18 18:33:16 PST
Pull request:
https://github.com/WebKit/WebKit/pull/38180
EWS
Comment 2
2025-01-14 06:06:24 PST
Committed
288842@main
(566fb370f6b3): <
https://commits.webkit.org/288842@main
> Reviewed commits have been landed. Closing PR #38180 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug