Bug 284835 – check-webkit-style: underscore false positive warning in multiline macros defining variables using other macros

• Status: NEW
• Component: Tools / Tests

[Lauro Moura]

When adding new Logging code to bug 284824, I added the following macro, like the ones in other `Logging.h` headers:

#define DECLARE_LOG_CHANNEL(name) \
    extern WTFLogChannel JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, name);

Here, JOIN_LOG_CHANNEL_WITH_PREFIX is another macro, defined in `Assertions.h`.

check-webkit-style output:

filename: Source/WebDriver/Logging.h, identifier: JOIN_LOG_CHANNEL_WITH_PREFIX, modified_identifier: JOIN_LOG_CHANNEL_WITH_PREFIX
ERROR: Source/WebDriver/Logging.h:55:  JOIN_LOG_CHANNEL_WITH_PREFIX is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]

Moving the macro body to the same line makes the problem vanish, but it's kinda going against the style in the other files.

[Radar WebKit Bug Importer]

<rdar://problem/142000732>