RESOLVED FIXED284780
[JSC] Remove stack height check for JSString::resolveToBuffer since we are using tail-calls 
https://bugs.webkit.org/show_bug.cgi?id=284780
Summary [JSC] Remove stack height check for JSString::resolveToBuffer since we are us...
Yusuke Suzuki
Reported 2024-12-16 14:24:10 PST
...
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-12-16 14:24:20 PST
<rdar://problem/141567781>
Yusuke Suzuki
Comment 2 2024-12-16 14:25:13 PST
Pull request: https://github.com/WebKit/WebKit/pull/38036
EWS
Comment 3 2024-12-16 16:20:56 PST
Committed 287916@main (f941f5ebc01f): <https://commits.webkit.org/287916@main> Reviewed commits have been landed. Closing PR #38036 and removing active labels.
Fujii Hironori
Comment 4 2024-12-16 23:59:19 PST
Windows port is crashing after this change. https://build.webkit.org/results/Windows-64-bit-Release-Tests/287926@main%20(1906)/results.html bug#283320 has disabled MUST_TAIL_CALL for Windows port. What should Windows port do?
Yusuke Suzuki
Comment 5 2024-12-17 02:20:30 PST
@Fujii Call `JSRopeString::resolveToBufferSlow` for all cases in resolveToBuffer. It can always handle things. Please keep the current thing as is for the other platforms. This is really important optimizations for, in particular, macOS / iOS x64 / ARM64.
Fujii Hironori
Comment 6 2024-12-17 03:33:15 PST
Thank you very much for the advice. I'm going to fix it in bug#284809.
Note You need to log in before you can comment on or make changes to this bug.