Bug 28478 - Modify page cache test to verify disabled cache too and to be usable as a template for page cache tests.
Summary: Modify page cache test to verify disabled cache too and to be usable as a tem...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Dmitry Titov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-19 18:25 PDT by Dmitry Titov
Modified: 2010-06-10 18:52 PDT (History)
0 users

See Also:


Attachments
Proposed patch (14.40 KB, patch)
2009-08-19 18:33 PDT, Dmitry Titov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-08-19 18:25:22 PDT
Previously introduced (Bug 28324) LayoutTests/fast/harness/use-page-cache.html verified that using overridePreference indeed enables page cache for a test.

As a follow up for the review comments in that bug, I've added a 'mirror' test that verifies that in the absence of override the page cache is disabled ('load' handler is called again when the window is navigated back to the same page).

Also, re-wrote test by moving all the JS into helper script so the use-page-cache.html can now be used as a simple template for page cache tests.
Comment 1 Dmitry Titov 2009-08-19 18:33:00 PDT
Created attachment 35173 [details]
Proposed patch
Comment 2 Dmitry Titov 2009-08-21 18:17:47 PDT
Comment on attachment 35173 [details]
Proposed patch

Removing r? because of Bugzilla memory loss - it was reviewed and discussed on IRC and agreed that it is not an optimal approach. I'll revisit this latter to see if it makes sense to have a 'template' for page cache tests.