Bug 28475 - Chromium: render disabled mute button if audio is not present
Summary: Chromium: render disabled mute button if audio is not present
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-19 17:09 PDT by Andrew Scherkus
Modified: 2009-08-21 14:46 PDT (History)
1 user (show)

See Also:


Attachments
Check for audio (1.61 KB, patch)
2009-08-19 17:26 PDT, Andrew Scherkus
levin: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Scherkus 2009-08-19 17:09:40 PDT
If hasAudio() returns false or the media is in an error state, display a disabled mute button.
Comment 1 Andrew Scherkus 2009-08-19 17:26:23 PDT
Created attachment 35164 [details]
Check for audio
Comment 2 David Levin 2009-08-19 21:38:57 PDT
Comment on attachment 35164 [details]
Check for audio

Made commit queue- pending Andrew's confirmation that the mediaSoundDisabled resource has been added on the Chromium side.
Comment 3 David Levin 2009-08-19 21:43:17 PDT
Comment on attachment 35164 [details]
Check for audio

I just found out that the resource is in.
Comment 4 Eric Seidel (no email) 2009-08-19 21:56:50 PDT
Comment on attachment 35164 [details]
Check for audio

Rejecting patch 35164 from commit-queue.  This patch will require manual commit.

Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
http://webkit.org/coding/contributing.html
Comment 5 Eric Seidel (no email) 2009-08-21 14:46:46 PDT
Looks like this was already landed.