RESOLVED FIXED 284738
[WebDriver][socket] true is set even if the acceptInsecureCerts is false 
https://bugs.webkit.org/show_bug.cgi?id=284738
Summary [WebDriver][socket] true is set even if the acceptInsecureCerts is false
haruhisa.shin
Reported 2024-12-15 23:04:38 PST
There was a mistake in https://commits.webkit.org/287707@main . > if (capabilitiesObject && capabilitiesObject->getBoolean("acceptInsecureCerts"_s)) > capabilities.acceptInsecureCertificates = true; The JSONObject::getBoolean() returns std::optional<bool>, not bool. So the above code would set variable acceptInsecureCertificates to true even if the JSON value is false.
Attachments
Add attachment proposed patch, testcase, etc.
haruhisa.shin
Comment 1 2024-12-15 23:36:42 PST
Pull request: https://github.com/WebKit/WebKit/pull/38002
EWS
Comment 2 2024-12-16 03:14:17 PST
Committed 287873@main (6572975a5c6e): <https://commits.webkit.org/287873@main> Reviewed commits have been landed. Closing PR #38002 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-12-16 03:15:15 PST
<rdar://problem/141538899>
Note You need to log in before you can comment on or make changes to this bug.