Because we rendering of underline is already tested, underline tests in /editing/style need not to be pixel tests. However, we care about whether texts are really underlined and what kind of markup is used to underline them. The current pixel test do not only reveal those information, and hence needs to be converted to dumpAsText tests with markup printed at the end.
Minimum set of tests that do require conversion. editing/style/remove-underline-across-paragraph-in-bold.html editing/style/remove-underline-across-paragraph.html editing/style/remove-underline-after-paragraph-in-bold.html editing/style/remove-underline-after-paragraph.html editing/style/remove-underline.html editing/style/underline.html
Created attachment 35144 [details] patch 1 of 3
Created attachment 35145 [details] 1 of 3 (removed irrelevant changes)
Created attachment 35154 [details] 1 of 3 (adding new runDumpAsTextEditingTest to editing.js)
Comment on attachment 35154 [details] 1 of 3 (adding new runDumpAsTextEditingTest to editing.js) Looks OK.
The first patch committed as http://trac.webkit.org/changeset/47533.
Created attachment 35170 [details] 2 of 3
Created attachment 35171 [details] 3 of 3
Comment on attachment 35170 [details] 2 of 3 Looks fine to me.
Comment on attachment 35171 [details] 3 of 3 Looks fine to me.
CCing justin so he sees these go by.
The second patch committed as http://trac.webkit.org/changeset/47542.
The third patch committed as http://trac.webkit.org/changeset/47543. The second patch wasn't committed properly and fixed in http://trac.webkit.org/changeset/47544.
Created attachment 38359 [details] additional patch for the record since Bugzilla data was lost
Fourth patch, which was r+ by Eric Seidel was committed as http://trac.webkit.org/changeset/47609.