Bug 28462 - WebCore causes linker warnings on Windows about multiply-defined JSHTMLDataListElement symbols
Summary: WebCore causes linker warnings on Windows about multiply-defined JSHTMLDataLi...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows XP
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-08-19 10:10 PDT by Adam Roben (:aroben)
Modified: 2009-08-19 10:15 PDT (History)
1 user (show)

See Also:

Patch v1 (5.07 KB, patch)
2009-08-19 10:10 PDT, Adam Roben (:aroben)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-08-19 10:10:41 PDT
Created attachment 35127 [details]
Patch v1

Reviewed by NOBODY (OOPS!).

Need a short description and bug URL (OOPS!)

* WebCore.vcproj/WebCore.vcproj: Exclude JSHTMLDataListElement.cpp
from the build (just like we do for the other generated bindings
files) so that we don't get warnings about multiply-defined symbols in
JSHTMLDataListElement.cpp and DerivedSources.cpp. Also removed
duplicate versions of JSSVGElementWrapperFactory.cpp, and let VS
reorder a few files.
 2 files changed, 59 insertions(+), 92 deletions(-)
Comment 1 Anders Carlsson 2009-08-19 10:12:28 PDT
Comment on attachment 35127 [details]
Patch v1

Comment 2 Adam Roben (:aroben) 2009-08-19 10:15:47 PDT
Committed r47508: http://trac.webkit.org/changeset/47508