WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
28462
WebCore causes linker warnings on Windows about multiply-defined JSHTMLDataListElement symbols
https://bugs.webkit.org/show_bug.cgi?id=28462
Summary
WebCore causes linker warnings on Windows about multiply-defined JSHTMLDataLi...
Adam Roben (:aroben)
Reported
2009-08-19 10:10:41 PDT
Created
attachment 35127
[details]
Patch v1 Reviewed by NOBODY (OOPS!). Need a short description and bug URL (OOPS!) * WebCore.vcproj/WebCore.vcproj: Exclude JSHTMLDataListElement.cpp from the build (just like we do for the other generated bindings files) so that we don't get warnings about multiply-defined symbols in JSHTMLDataListElement.cpp and DerivedSources.cpp. Also removed duplicate versions of JSSVGElementWrapperFactory.cpp, and let VS reorder a few files. --- 2 files changed, 59 insertions(+), 92 deletions(-)
Attachments
Patch v1
(5.07 KB, patch)
2009-08-19 10:10 PDT
,
Adam Roben (:aroben)
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2009-08-19 10:12:28 PDT
Comment on
attachment 35127
[details]
Patch v1 r=me
Adam Roben (:aroben)
Comment 2
2009-08-19 10:15:47 PDT
Committed
r47508
:
http://trac.webkit.org/changeset/47508
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug