Bug 28461 – transitions/change-values-during-transition.html fails intermittently

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Rowe (bdash)]

transitions/change-values-during-transition.html has been failing intermittently on the new leaks bot: <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r47504%20(13)/transitions/change-values-during-transition-pretty-diff.html>.  This is presumably due to the extra overhead that comes from running with MallocStackLogging enabled.  We should make the test more robust so that it doesn't fail in this manner.

[Eric Seidel (no email)]

Another one tonight:
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r48958%20(1067)/results.html

Seems to be a bunch of transition related intermittent failures on the SnowLeopard bot, maybe they all have one root cause?

transitions/change-values-during-transition.html:
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r48958%20(1067)/results.html

transitions/cancel-transition.html:
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r48945%20(1056)/results.html

I was looking at adding the SnowLeopard bots to the list of bots to block commits from the commit-queue this evening.  Looks like they're not quite ready, this bug being one of the blockers. (bugzilla-tool, and thus the commit-queue, will not allow one to commit if the bots are red.  Currently the SnowLeopard bots are not in the set of bots it checks, but once they are stable green I would like them to be.)

[Mihai Parparita]

Created attachment 64641 [details]
Patch

[Mihai Parparita]

I just ran into this while trying to land 44086 via the commit queue. The attached patch should hopefully make it less flaky.

[Chris Marrin]

Comment on attachment 64641 [details]
Patch

r=me. This is a good technique for many of these transition/animation tests. We might want to use it elsewhere, or even put it into one of the JS helpers.

[WebKit Commit Bot]

Comment on attachment 64641 [details]
Patch

Rejecting patch 64641 from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your reviewer rights.

[Dimitri Glazkov (Google)]

Comment on attachment 64641 [details]
Patch

Chris, you need to teach commit-queue a lesson! :P

[WebKit Commit Bot]

Comment on attachment 64641 [details]
Patch

Clearing flags on attachment: 64641

Committed r65575: <http://trac.webkit.org/changeset/65575>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.