Bug 28450 - commit-queue/bugzilla-tool should build both Debug and Release
Summary: commit-queue/bugzilla-tool should build both Debug and Release
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-08-19 00:39 PDT by Eric Seidel (no email)
Modified: 2010-01-03 19:12 PST (History)
3 users (show)

See Also:

Patch (8.41 KB, patch)
2010-01-03 18:57 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-08-19 00:39:43 PDT
commit-queue/bugzilla-tool should build both Debug and Release

We're currently building whatever is the current "set-webkit-configuration" value.  Which on the commit-queue machine is "release".  We should probably change --commit-queue mode to build both, and possibly even run the LayoutTests in Debug mode instead of release mode (Debug will catch ASSERTs).

Ideally this would all be handled by try-bots, but we'll use what we have for now. :)

Tonight the commit-queue landed a patch which build and passed in release, but crashed 10 tests run in Debug mode (due to an ASSERT).  This bug is about preventing such problems.
Comment 1 Eric Seidel (no email) 2009-12-19 23:27:27 PST
This will be much easier to do once we make the layout tests much faster using the fancy new fully-sharded run_webkit_tests.py.
Comment 2 Adam Barth 2010-01-03 18:57:04 PST
Created attachment 45762 [details]
Comment 3 WebKit Review Bot 2010-01-03 19:02:02 PST
style-queue ran check-webkit-style on attachment 45762 [details] without any errors.
Comment 4 Eric Seidel (no email) 2010-01-03 19:03:59 PST
Comment on attachment 45762 [details]

Comment 5 WebKit Commit Bot 2010-01-03 19:12:42 PST
Comment on attachment 45762 [details]

Clearing flags on attachment: 45762

Committed r52701: <http://trac.webkit.org/changeset/52701>
Comment 6 WebKit Commit Bot 2010-01-03 19:12:48 PST
All reviewed patches have been landed.  Closing bug.