commit-queue/bugzilla-tool should build both Debug and Release We're currently building whatever is the current "set-webkit-configuration" value. Which on the commit-queue machine is "release". We should probably change --commit-queue mode to build both, and possibly even run the LayoutTests in Debug mode instead of release mode (Debug will catch ASSERTs). Ideally this would all be handled by try-bots, but we'll use what we have for now. :) Tonight the commit-queue landed a patch which build and passed in release, but crashed 10 tests run in Debug mode (due to an ASSERT). This bug is about preventing such problems.
This will be much easier to do once we make the layout tests much faster using the fancy new fully-sharded run_webkit_tests.py.
Created attachment 45762 [details] Patch
style-queue ran check-webkit-style on attachment 45762 [details] without any errors.
Comment on attachment 45762 [details] Patch LGTM.
Comment on attachment 45762 [details] Patch Clearing flags on attachment: 45762 Committed r52701: <http://trac.webkit.org/changeset/52701>
All reviewed patches have been landed. Closing bug.