RESOLVED FIXED 284491
AX: When Safari is full-screen, AXIsolatedObject::screenRelativePosition() hits the main-thread unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=284491
Summary AX: When Safari is full-screen, AXIsolatedObject::screenRelativePosition() hi...
Tyler Wilcock
Reported 2024-12-11 14:31:10 PST
This happens because after https://bugs.webkit.org/show_bug.cgi?id=267957, AXIsolatedObject::screenRelativePosition() uses the cached root screen relative position to compute the screen relative position for every other object. But because we intentionally don't cache properties that are in their default-value state, we wouldn't cache AXPropertyName::ScreenRelativePosition {0, 0} for the root (which is the right value when Safari is full-screen). Thus, this: if (auto rootPoint = rootNode->optionalAttributeValue<FloatPoint>(AXPropertyName::ScreenRelativePosition)) Fails to evaluate to true, and we hit the main-thread.
Attachments
Radar WebKit Bug Importer
Comment 1 2024-12-11 14:31:20 PST
Tyler Wilcock
Comment 2 2024-12-11 21:10:27 PST
EWS
Comment 3 2024-12-12 11:10:30 PST
Committed 287754@main (969b96235a07): <https://commits.webkit.org/287754@main> Reviewed commits have been landed. Closing PR #37818 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.