WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
284480
Remove unreachable code from Python tools
https://bugs.webkit.org/show_bug.cgi?id=284480
Summary
Remove unreachable code from Python tools
Sam Sneddon [:gsnedders]
Reported
2024-12-11 12:42:37 PST
https://commits.webkit.org/287424@main
accidentally left some dead code from ruff's UP036 fixer. For example: ``` @classmethod def gmtoffset(cls): - if sys.version_info >= (3, 0): - return int(time.localtime().tm_gmtoff * 100 / (60 * 60)) + return int(time.localtime().tm_gmtoff * 100 / (60 * 60)) ts = time.time() return int((datetime.fromtimestamp(ts) - datetime.utcfromtimestamp(ts)).total_seconds() * 100 / (60 * 60)) ```
Attachments
Add attachment
proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1
2024-12-11 12:53:09 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37791
EWS
Comment 2
2024-12-11 13:19:16 PST
Committed
287692@main
(b7a2c9869a47): <
https://commits.webkit.org/287692@main
> Reviewed commits have been landed. Closing PR #37791 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-12-11 13:20:15 PST
<
rdar://problem/141310025
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug