WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
284478
[AutoInstall] Always uses pypi.org, ignores pip.conf
https://bugs.webkit.org/show_bug.cgi?id=284478
Summary
[AutoInstall] Always uses pypi.org, ignores pip.conf
Sam Sneddon [:gsnedders]
Reported
2024-12-11 12:32:42 PST
webkitcorepy.autoinstall has: ```python def _default_pypi_index(): return 'pypi.org' pypi_url = re.compile(r'\Aindex\S* = https?://(?P<host>\S+)/.*') pip_config = '/Library/Application Support/pip/pip.conf' if os.path.isfile(pip_config): with open(pip_config, 'r') as config: for line in config.readlines(): match = pypi_url.match(line.lstrip()) if match: return match.group('host') return 'pypi.org' ``` Fairly obviously, everything after the initial return is dead code. Behaviour here changed in
https://github.com/WebKit/WebKit/commit/3f8cbc3426c78930f3b7238372e6e1a953864549
(
bug 275332
), but neither the commit message nor the PR nor the bug give any evidence as to why this change was made. I presume it might be accidentally from during development?
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-12-11 12:33:01 PST
<
rdar://problem/141306004
>
Jonathan Bedard
Comment 2
2024-12-11 12:43:42 PST
This was not deliberate, posting a fix now.
Jonathan Bedard
Comment 3
2024-12-11 12:46:15 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37790
EWS
Comment 4
2024-12-11 15:57:09 PST
Committed
287704@main
(f7e269f60320): <
https://commits.webkit.org/287704@main
> Reviewed commits have been landed. Closing PR #37790 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug