RESOLVED FIXED284470
Web Automation: modernize callback thunks for async protocol commands 
https://bugs.webkit.org/show_bug.cgi?id=284470
Summary Web Automation: modernize callback thunks for async protocol commands
Blaze Burg
Reported 2024-12-11 09:35:49 PST
We need to be able to connect async WebAutomationSession/WebAutomationBidiProcessor methods to each other. Right now these callbacks are all BackendDispatcher::CallbackBase subclasses, which does not have a standalone constructor. So, we cannot easily pass a lambda that chains completion handlers. In order to chain callbacks, switch from using CallbackBase subclasses to using Function<> with proper type parameters. NB. We may consider using CompletionHandlers in some places, but for now the types are expressed using the less strict Function template.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-12-11 09:52:44 PST
<rdar://problem/141291944>
Blaze Burg
Comment 2 2025-02-21 10:48:03 PST
Pull request: https://github.com/WebKit/WebKit/pull/41067
EWS
Comment 3 2025-02-27 18:03:26 PST
Committed 291284@main (9e1b4bc5f110): <https://commits.webkit.org/291284@main> Reviewed commits have been landed. Closing PR #41067 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.