Bug 28445 - webkit-patch post can post partial diffs from SVN checkouts.
Summary: webkit-patch post can post partial diffs from SVN checkouts.
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 28436
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-18 22:33 PDT by Eric Seidel (no email)
Modified: 2010-06-10 20:31 PDT (History)
2 users (show)

See Also:


Attachments
easy fix, will write test once bug 28436 lands (523 bytes, patch)
2009-08-19 17:55 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-08-18 22:33:40 PDT
https://bugs.webkit.org/attachment.cgi?id=35096&action=edit

is an example.

We need to chdir to the root of the repository before calling out to svn-create-patch. Either by passing a working directory to svn-create-patch, or doing a chdir to the root first, or whatever.
Comment 1 Eric Seidel (no email) 2009-08-19 17:55:18 PDT
Created attachment 35168 [details]
easy fix, will write test once bug 28436 lands
Comment 2 Eric Seidel (no email) 2009-08-19 17:55:45 PDT
I want to use some of the testing infrastructure I added in bug 28436 when writing this test.
Comment 3 Adam Barth 2009-08-20 23:08:16 PDT
Committed r47598: <http://trac.webkit.org/changeset/47598>
Comment 4 Eric Seidel (no email) 2009-09-18 14:13:03 PDT
This change was requested by Maciej after confusion:
https://bugs.webkit.org/show_bug.cgi?id=27937#c5
Comment 5 Eric Seidel (no email) 2009-09-19 11:18:32 PDT
After discussion via email, the consensus is that we should roll out this change.  When we do so, we should add some unit tests to scm_unittest.py to document the intentionally different post-diff behavior between svn and git (which matches how their various diff commands operate).
Comment 6 Eric Seidel (no email) 2010-01-19 16:43:31 PST
I'm not a svn user.  I'm not sure if this is still an issue.