WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
28445
webkit-patch post can post partial diffs from SVN checkouts.
https://bugs.webkit.org/show_bug.cgi?id=28445
Summary
webkit-patch post can post partial diffs from SVN checkouts.
Eric Seidel (no email)
Reported
2009-08-18 22:33:40 PDT
https://bugs.webkit.org/attachment.cgi?id=35096&action=edit
is an example. We need to chdir to the root of the repository before calling out to svn-create-patch. Either by passing a working directory to svn-create-patch, or doing a chdir to the root first, or whatever.
Attachments
easy fix, will write test once bug 28436 lands
(523 bytes, patch)
2009-08-19 17:55 PDT
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-08-19 17:55:18 PDT
Created
attachment 35168
[details]
easy fix, will write test once
bug 28436
lands
Eric Seidel (no email)
Comment 2
2009-08-19 17:55:45 PDT
I want to use some of the testing infrastructure I added in
bug 28436
when writing this test.
Adam Barth
Comment 3
2009-08-20 23:08:16 PDT
Committed
r47598
: <
http://trac.webkit.org/changeset/47598
>
Eric Seidel (no email)
Comment 4
2009-09-18 14:13:03 PDT
This change was requested by Maciej after confusion:
https://bugs.webkit.org/show_bug.cgi?id=27937#c5
Eric Seidel (no email)
Comment 5
2009-09-19 11:18:32 PDT
After discussion via email, the consensus is that we should roll out this change. When we do so, we should add some unit tests to scm_unittest.py to document the intentionally different post-diff behavior between svn and git (which matches how their various diff commands operate).
Eric Seidel (no email)
Comment 6
2010-01-19 16:43:31 PST
I'm not a svn user. I'm not sure if this is still an issue.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug