Bug 28443 - Build break with gtk 2.10
Summary: Build break with gtk 2.10
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-18 20:50 PDT by Fumitoshi Ukai
Modified: 2009-08-18 23:49 PDT (History)
1 user (show)

See Also:

Attachments
fix build break with gtk_widget_get_window (1.23 KB, patch)
2009-08-18 21:00 PDT, Fumitoshi Ukai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2009-08-18 20:50:53 PDT 
WebKit requires gtk 2.10, but WebKit/gtk/WebCoreSupport/DragClientGtk.cpp requires gtk_widget_get_window that is introduced in gtk 2.14.

../WebKit/gtk/WebCoreSupport/DragClientGtk.cpp: In member function ‘virtual void WebKit::DragClient::startDrag(GdkPixbuf*, const WebCore::IntPoint&, const WebCore::IntPoint&, WebCore::Clipboard*, WebCore::Frame*, bool)’:
../WebKit/gtk/WebCoreSupport/DragClientGtk.cpp:92: error: ‘gtk_widget_get_window’ was not declared in this scope
make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-DragClientGtk.lo] Error 1
Comment 1 Fumitoshi Ukai 2009-08-18 21:00:10 PDT 
Created attachment 35100 [details]
fix build break with gtk_widget_get_window


---
 2 files changed, 17 insertions(+), 1 deletions(-)
Comment 2 Eric Seidel (no email) 2009-08-18 23:35:10 PDT 
Comment on attachment 35100 [details]
fix build break with gtk_widget_get_window

Looks sane enough.
Comment 3 Eric Seidel (no email) 2009-08-18 23:49:52 PDT 
Comment on attachment 35100 [details]
fix build break with gtk_widget_get_window

Clearing flags on attachment: 35100

Committed r47496: <http://trac.webkit.org/changeset/47496>
Comment 4 Eric Seidel (no email) 2009-08-18 23:49:56 PDT 
All reviewed patches have been landed.  Closing bug.