RESOLVED FIXED 284311
[CMake][LibWebRTC] Fix build after 287443@main 
https://bugs.webkit.org/show_bug.cgi?id=284311
Summary [CMake][LibWebRTC] Fix build after 287443@main
Diego Pino
Reported 2024-12-09 12:03:52 PST
On ARM platforms that do not support SVE, the build is failing with the following linking error: FAILED: lib/libWPEWebKit-2.0.so.2.4.1 : && /usr/bin/clang++-18 -fPIC -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -Werror=undefined-internal -Werror=undefined-inline -pipe -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fasynchronous-unwind-tables -fdebug-types-section -fno-strict-aliasing -fno-exceptions -fno-rtti -fcoroutines -ffunction-sections -fdata-sections -O3 -DNDEBUG -Wl,--no-undefined -L/home/pwuser/webkit/WebKitBuild/DependenciesWPE/Root/lib -Wl,--gc-sections -Wl,--disable-new-dtags -Wl,--version-script,/home/pwuser/webkit/Source/WebKit/webkitglib-symbols.map -shared -Wl,-soname,libWPEWebKit-2.0.so.2 -o lib/libWPEWebKit-2.0.so.2.4.1 @CMakeFiles/WebKit.rsp && : /usr/bin/ld: lib/libwebrtc.a(convert.cc.o): in function `ARGBToI420': convert.cc:(.text.ARGBToI420+0xe8): undefined reference to `ARGBToUVRow_SVE2 ' /usr/bin/ld: convert.cc:(.text.ARGBToI420+0xf4): undefined reference to `ARGBToUVRow_SVE2' /usr/bin/ld: lib/libwebrtc.a(row_any.cc.o): in function `ARGBToUVRow_Any_SVE2': row_any.cc:(.text.ARGBToUVRow_Any_SVE2+0x7c): undefined reference to `ARGBToUVRow_SVE2' /usr/bin/ld: row_any.cc:(.text.ARGBToUVRow_Any_SVE2+0xe8): undefined reference to `ARGBToUVRow_SVE2' clang++-18: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. Changeset 287443@main disables SVE in Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig: https://github.com/WebKit/WebKit/compare/865625bf942f%5E..865625bf942f#diff-2752c88e71f5346a457e0b6f67849c67ea4217f918d7966cd8561dc2a9e1765dR11 So probably a similar change should fix the build.
Attachments
Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2024-12-09 12:05:38 PST
Pull request: https://github.com/webkit/webkit/pull/37652
EWS
Comment 2 2024-12-09 22:59:34 PST
Committed 287592@main (622a57b04519): <https://commits.webkit.org/287592@main> Reviewed commits have been landed. Closing PR #37652 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-12-09 23:00:15 PST
<rdar://problem/141201617>
Note You need to log in before you can comment on or make changes to this bug.