Bug 284275 – [WTF] Remove more COMPILER(MSVC)

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

...

[Radar WebKit Bug Importer]

<rdar://problem/141139058>

[Yusuke Suzuki]

Pull request: https://github.com/WebKit/WebKit/pull/37623

[EWS]

Committed 287582@main (0385b66e0291): <https://commits.webkit.org/287582@main>

Reviewed commits have been landed. Closing PR #37623 and removing active labels.

[Fujii Hironori]

Surprising it can't compile on my PC even though buildbots are fine.

[63/6972] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\ParkingLot.cpp.obj
FAILED: Source/WTF/wtf/CMakeFiles/WTF.dir/ParkingLot.cpp.obj
C:\PROGRA~1\LLVM\bin\clang-cl.exe  /nologo -TP -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WTF -DHAVE_CONFIG_H=1 -DNOCRYPT -DNOMINMAX -DNTDDI_VERSION=0x0A000006 -DPAS_BMALLOC=1 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_HAS_EXCEPTIONS=0 -D_SILENCE_CXX23_DENORM_DEPRECATION_WARNING -D_UNICODE -D_WIN32_WINNT=0x0A00 -D_WINDOWS -D_WINSOCKAPI_="" -IC:\webkit\wb\WebKitBuild\Debug -IC:\webkit\wb\WebKitBuild\Debug\WTF\DerivedSources -IC:\webkit\wb\Source\WTF -IC:\webkit\wb\Source\WTF\wtf -IC:\webkit\wb\Source\WTF\wtf\dtoa -IC:\webkit\wb\Source\WTF\wtf\fast_float -IC:\webkit\wb\Source\WTF\wtf\persistence -IC:\webkit\wb\Source\WTF\wtf\simdutf -IC:\webkit\wb\Source\WTF\wtf\text -IC:\webkit\wb\Source\WTF\wtf\text\icu -IC:\webkit\wb\Source\WTF\wtf\threads -IC:\webkit\wb\Source\WTF\wtf\unicode -imsvcC:\webkit\wb\WebKitLibraries\win\include /Zc:dllexportInlines- /W4 -fcolor-diagnostics -Werror=undefined-internal -Werror=undefined-inline -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align /DWIN32 /D_WINDOWS  -fno-strict-aliasing /Zi /Ob0 /Od /RTC1 -clang:-std=c++23 -MD /clang:-masm=att /Zi /GS /EHa- /EHc- /EHs- /fp:except- /GR- /analyze- /bigobj /utf-8 /validate-charset /WX /showIncludes /FoSource\WTF\wtf\CMakeFiles\WTF.dir\ParkingLot.cpp.obj /FdSource\WTF\wtf\CMakeFiles\WTF.dir\ -c -- C:\webkit\wb\Source\WTF\wtf\ParkingLot.cpp
In file included from C:\webkit\wb\Source\WTF\wtf\ParkingLot.cpp:33:
In file included from C:\webkit\wb\Source\WTF\wtf/ThreadSpecific.h:47:
In file included from C:\webkit\wb\Source\WTF\wtf/Threading.h:49:
In file included from C:\webkit\wb\Source\WTF\wtf/StackBounds.h:30:
C:\webkit\wb\Source\WTF\wtf/StackPointer.h(55,37): error: unknown attribute '__cdecl' ignored [-Werror,-Wunknown-attributes]
   55 | extern "C" WTF_EXPORT_PRIVATE void* CDECL currentStackPointer(void);
      |                                     ^~~~~
C:\webkit\wb\Source\WTF\wtf/PlatformCallingConventions.h(68,31): note: expanded from macro 'CDECL'
   68 | #define CDECL __attribute__ ((__cdecl))
      |                               ^~~~~~~
1 error generated.

"__attribute__ ((__cdecl))" should be "__attribute__ ((cdecl))".
https://gcc.gnu.org/onlinedocs/gcc/x86-Function-Attributes.html

I don't know why buildbots don't complain.
My guess is that it include <windows.h> before PlatformCallingConventions.h.
Anyway, I'm going to land a fix.

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/37686

[Fujii Hironori]

(In reply to Fujii Hironori from comment #4)
> I don't know why buildbots don't complain.
> My guess is that it include <windows.h> before PlatformCallingConventions.h.

It's a warning. And, EWS is using --no-fatal-warnings

[Fujii Hironori]

(In reply to Fujii Hironori from comment #6)
> And, EWS is using --no-fatal-warnings

No. Only post-commit buildbot is using --no-fatal-warnings.
I don't know why EWS didn't catch the error.

[EWS]

Committed 287591@main (eea1b4697d73): <https://commits.webkit.org/287591@main>

Reviewed commits have been landed. Closing PR #37686 and removing active labels.