RESOLVED FIXED 284257
Cleanup unnecessary duplicated "visitorAdditionalChildren" methods in Observable code 
https://bugs.webkit.org/show_bug.cgi?id=284257
Summary Cleanup unnecessary duplicated "visitorAdditionalChildren" methods in Observa...
Marais Rossouw
Reported 2024-12-08 18:25:58 PST
We have a method called "visitorAdditionalChildren" on our base InternalObserver class, which requires implementations for both AbstractSlotVisitor, and SlotVisitor. This is not required, as AbstractSlotVisitor is a base class to SlotVisitor — so we only need one.
Attachments
Add attachment proposed patch, testcase, etc.
Marais Rossouw
Comment 1 2024-12-08 18:33:09 PST
Pull request: https://github.com/WebKit/WebKit/pull/37610
EWS
Comment 2 2024-12-09 07:15:17 PST
Committed 287546@main (d2eb155406a3): <https://commits.webkit.org/287546@main> Reviewed commits have been landed. Closing PR #37610 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-12-09 07:16:16 PST
<rdar://problem/141155142>
Note You need to log in before you can comment on or make changes to this bug.