Bug 28423 - Two layout tests are convertible to dumpAsText
Summary: Two layout tests are convertible to dumpAsText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-18 03:55 PDT by Yuta Kitamura
Modified: 2009-08-19 18:31 PDT (History)
1 user (show)

See Also:


Attachments
Convert two layout tests so that they use dumpAsText(). (8.18 KB, patch)
2009-08-18 04:13 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff
Convert two layout tests so that they use dumpAsText(). (7.85 KB, patch)
2009-08-18 19:25 PDT, Yuta Kitamura
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
Convert two layout tests so that they use dumpAsText(). (v3) (7.98 KB, patch)
2009-08-19 03:15 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2009-08-18 03:55:44 PDT
The following tests are convertible to dumpAsTest.
- fast/multicol/negativeColumnWidth.html
- fast/multicol/zeroColumnCount.html

Since these tests check if the renderer crashes or not when it opens these evil cases, we can safely convert them so they use dumpAsText().
Comment 1 Yuta Kitamura 2009-08-18 04:13:29 PDT
Created attachment 35035 [details]
Convert two layout tests so that they use dumpAsText().

These tests check if the renderer crashes or not. Hence, we do not need to
dump the entire render tree. I verified DumpRenderTree at r24513 still crashed
when it opened the updated test cases.

See bug 14714 for details about these test cases.
---
 13 files changed, 54 insertions(+), 54 deletions(-)
Comment 2 Eric Seidel (no email) 2009-08-18 15:01:44 PDT
Comment on attachment 35035 [details]
Convert two layout tests so that they use dumpAsText().

I would rather have "technically invalid" html, than tests full of a bunch of boiler-plate.


This test succeeds if it does not crash.

<table<td style="-webkit-columns: -9999px;">
<script>
if (window.layoutTestController)
   layoutTestController.dumpAsText()
</script>

would have been sufficient.

WebKit style is 4 space indent.  so r-.
Comment 3 Yuta Kitamura 2009-08-18 18:51:49 PDT
Alright. I'm going to give it a second try.
Comment 4 Yuta Kitamura 2009-08-18 19:25:33 PDT
Created attachment 35097 [details]
Convert two layout tests so that they use dumpAsText().

These tests check if the renderer crashes or not. Hence, we do not need to
dump the entire render tree. I verified DumpRenderTree at r24513 still crashed
when it opened the updated test cases.

See bug 14714 for details about these test cases.
---
 13 files changed, 42 insertions(+), 52 deletions(-)
Comment 5 Eric Seidel (no email) 2009-08-18 23:36:27 PDT
Comment on attachment 35097 [details]
Convert two layout tests so that they use dumpAsText().

Hopefully svn-apply will handle this git-diff correctly.  :)  LGTM.
Comment 6 Eric Seidel (no email) 2009-08-18 23:41:57 PDT
Comment on attachment 35097 [details]
Convert two layout tests so that they use dumpAsText().

Rejecting patch 35097 from commit-queue.  This patch will require manual commit.

Patch https://bugs.webkit.org/attachment.cgi?id=35097 from bug 28423 failed to download and apply.
Comment 7 Yuta Kitamura 2009-08-18 23:59:02 PDT
Eric, thank you for your review!

Unfortunately auto-commit didn't work (maybe because of file removal?), and I don't have committer's access yet, so I'm waiting for somebody's manual commit.
Comment 8 Eric Seidel (no email) 2009-08-19 00:34:15 PDT
Applying 35097 from bug 28423.
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/multicol/negativeColumnWidth-expected.txt
patching file LayoutTests/fast/multicol/negativeColumnWidth.html
patching file LayoutTests/fast/multicol/zeroColumnCount-expected.txt
patching file LayoutTests/fast/multicol/zeroColumnCount.html
patching file LayoutTests/platform/mac/fast/multicol/negativeColumnWidth-expected.checksum
rm 'LayoutTests/platform/mac/fast/multicol/negativeColumnWidth-expected.checksum'
patch: **** Only garbage was found in the patch input.
patch -p0 "LayoutTests/platform/mac/fast/multicol/negativeColumnWidth-expected.png" returned 2.  Pass --force to ignore patch failures.

svn-apply doesn't seem to understand this git diff.  Possibly a bug in svn-apply.  You can get around this by using svn-create-patch.
Comment 9 Yuta Kitamura 2009-08-19 01:35:13 PDT
OK, I'm going to have a svn checkout and try to create a patch with svn-create-patch. It may take some time.
Comment 10 Yuta Kitamura 2009-08-19 03:15:02 PDT
Created attachment 35114 [details]
Convert two layout tests so that they use dumpAsText(). (v3)

svn-apply should work fine with this patch.
Comment 11 Eric Seidel (no email) 2009-08-19 08:52:00 PDT
Comment on attachment 35114 [details]
Convert two layout tests so that they use dumpAsText(). (v3)

I filed bug 28456 about the svn-apply problem.

Looks fine.
Comment 12 Eric Seidel (no email) 2009-08-19 10:38:03 PDT
Comment on attachment 35114 [details]
Convert two layout tests so that they use dumpAsText(). (v3)

Clearing flags on attachment: 35114

Committed r47510: <http://trac.webkit.org/changeset/47510>
Comment 13 Eric Seidel (no email) 2009-08-19 10:38:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Yuta Kitamura 2009-08-19 18:31:35 PDT
Thanks for all your work!