Bug 284216 – Create WebKitWebExtensionMatchPattern API for WebKitGTK

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jamie Murphy]

This API exposes WebExtensionMatchPattern support to WebKitGtk, which can then be used by future implementations of WebExtension and WebExtensionContext.

[Jamie Murphy]

Pull request: https://github.com/WebKit/WebKit/pull/37582

[EWS]

Committed 288424@main (b2a4be47a0aa): <https://commits.webkit.org/288424@main>

Reviewed commits have been landed. Closing PR #37582 and removing active labels.

[Diego Pino]

After this patch, the 'GTK-Linux-64-bit-Release-Debian-Stable-Build' bot is failing with the following error:

https://build.webkit.org/#/builders/46/builds/46081

```
/home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:641:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE’ was not declared in this scope; did you mean ‘WEBKIT_TYPE_WEB_EXTENSION_MATCH_PATTERN_OPTIONS’?
  641 |         { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE", "none" },
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |           WEBKIT_TYPE_WEB_EXTENSION_MATCH_PATTERN_OPTIONS
/home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:642:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES’ was not declared in this scope; did you mean ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_SCHEME’?
  642 |         { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES", "ignore-schemes" },
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |           WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_SCHEME
/home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:643:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS’ was not declared in this scope; did you mean ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_PATH’?
  643 |         { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS", "ignore-paths" },
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |           WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_PATH
/home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:644:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY’ was not declared in this scope
  644 |         { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY", "match-bidirectionally" },
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

[Diego Pino]

Re-opening for pull request https://github.com/webkit/webkit/pull/38530

[EWS]

Committed 288434@main (1ddcb1544050): <https://commits.webkit.org/288434@main>

Reviewed commits have been landed. Closing PR #38530 and removing active labels.

[Diego Pino]

After landing the patch before, there was another build error reported by 'GTK-Linux-64-bit-Release-Ubuntu-LTS-Build':

https://build.webkit.org/#/builders/68/builds/39352

```
/home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/Source/WebKit/UIProcess/API/glib/WebKitWebExtensionMatchPattern.cpp:393:12: error: return-statement with a value, in function returning ‘void’ [-fpermissive]
  393 |     return nullptr;
      |            ^~~~~~~
```

[Diego Pino]

Re-opening for pull request https://github.com/webkit/webkit/pull/38531

[EWS]

Committed 288435@main (d812f50c13b6): <https://commits.webkit.org/288435@main>

Reviewed commits have been landed. Closing PR #38531 and removing active labels.

[Philippe Normand]

(In reply to Diego Pino from comment #3)
> After this patch, the 'GTK-Linux-64-bit-Release-Debian-Stable-Build' bot is
> failing with the following error:
> 
> https://build.webkit.org/#/builders/46/builds/46081
> 
> ```
> /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/
> WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:
> 641:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE’ was not
> declared in this scope; did you mean
> ‘WEBKIT_TYPE_WEB_EXTENSION_MATCH_PATTERN_OPTIONS’?
>   641 |         { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE,
> "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE", "none" },
>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |           WEBKIT_TYPE_WEB_EXTENSION_MATCH_PATTERN_OPTIONS
> /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/
> WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:
> 642:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES’
> was not declared in this scope; did you mean
> ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_SCHEME’?
>   642 |         { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES,
> "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES",
> "ignore-schemes" },
>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |           WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_SCHEME
> /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/
> WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:
> 643:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS’ was
> not declared in this scope; did you mean
> ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_PATH’?
>   643 |         { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS,
> "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS", "ignore-paths" },
>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |           WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_PATH
> /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/
> WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:
> 644:11: error:
> ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY’ was not
> declared in this scope
>   644 |         {
> WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY,
> "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY",
> "match-bidirectionally" },
>       |          
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ```

That happens because there's a spurious WK_WEB_EXTENSIONS ifdef in Source/WebKit/UIProcess/API/glib/webkit.h.in...

[Philippe Normand]

Re-opening for another PR.

[Philippe Normand]

Pull request: https://github.com/WebKit/WebKit/pull/38541

[EWS]

Committed 288441@main (2df70530c94c): <https://commits.webkit.org/288441@main>

Reviewed commits have been landed. Closing PR #38541 and removing active labels.

[Philippe Normand]

WebKitWebExtensionMatchPattern.h is GTK-specific, shouldn't be included in WPE's webkit.h. Re-opening for follow-up.

[Philippe Normand]

Pull request: https://github.com/WebKit/WebKit/pull/38542

[EWS]

Committed 288442@main (42a7911be14f): <https://commits.webkit.org/288442@main>

Reviewed commits have been landed. Closing PR #38542 and removing active labels.