WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
284205
Recompute event target when removed from changing selection
https://bugs.webkit.org/show_bug.cgi?id=284205
Summary
Recompute event target when removed from changing selection
Ahmad Saleem
Reported
2024-12-06 16:28:10 PST
Hi Team, While going through Blink's commit, I came across another failing test. Test Case (need to run via - run-webkit-tests): In Commit ^ fails on WebKit ToT. Blink Commit:
https://chromium.googlesource.com/chromium/blink/+/f2696796968c131cf121536fd8c5f87d801d90a7
WebKit Source:
https://searchfox.org/wubkat/rev/52d16c972a163b36fe64a99efb66af93c6e2f2b2/Source/WebCore/page/EventHandler.cpp#1973
``` static inline bool shouldRefetchEventTarget(const MouseEventWithHitTestResults& mouseEvent) { RefPtr targetNode = mouseEvent.targetNode(); RefPtr shadowRoot = dynamicDowncast<ShadowRoot>(*targetNode); ASSERT(targetNode); if (!targetNode->parentNode()) return true; return shadowRoot && is<HTMLInputElement>(shadowRoot->host()); } and corresponding call site. ``` ^ this compiles and fix the test case. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-12-06 18:59:47 PST
<
rdar://problem/141080146
>
Ahmad Saleem
Comment 2
2024-12-06 19:07:39 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37576
EWS
Comment 3
2024-12-10 11:27:05 PST
Committed
287619@main
(18561227325c): <
https://commits.webkit.org/287619@main
> Reviewed commits have been landed. Closing PR #37576 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug