RESOLVED FIXED 284083
Build failure - WebGPUHDREnabled Feature's status implies it should be on by default 
https://bugs.webkit.org/show_bug.cgi?id=284083
Summary Build failure - WebGPUHDREnabled Feature's status implies it should be on by...
Matt Woodrow
Reported 2024-12-04 17:56:36 PST
Users/mattwoodrow/src/safari/OpenSource/Source/WebKit/UIProcess/API/APIFeature.h:43:27: error: static assertion failed due to requirement 'defaultValue': Feature's status implies it should be on by default 43 | static_assert(defaultValue, "Feature's status implies it should be on by default"); /Users/mattwoodrow/src/safari/OpenSource/WebKitBuild/Release/DerivedSources/WebKit/WebPreferencesFeatures.cpp:968:23: note: in instantiation of function template specialization 'API::Feature::create<API::FeatureStatus::Stable, false>' requested here 968 | API::Feature::create("WebGPU support for HDR"""_s, "WebGPUHDREnabled"_s, API::FeatureConstant<API::FeatureStatus::Webgpu_feature_status>{}, API::FeatureCategory::DOM, "WebGPU High Dynamic Range through canvas configuration tone mapping mode"""_s, DEFAULT_VALUE_FOR_WebGPUHDREnabled, false),
Attachments
Add attachment proposed patch, testcase, etc.
Matt Woodrow
Comment 1 2024-12-04 18:07:25 PST
Pull request: https://github.com/WebKit/WebKit/pull/37470
EWS
Comment 2 2024-12-04 20:24:05 PST
Committed 287384@main (cd157b83b638): <https://commits.webkit.org/287384@main> Reviewed commits have been landed. Closing PR #37470 and removing active labels.
Jonathan Bedard
Comment 3 2024-12-05 06:40:03 PST
*** Bug 284107 has been marked as a duplicate of this bug. ***
Radar WebKit Bug Importer
Comment 4 2024-12-05 06:40:26 PST
<rdar://problem/140976998>
Note You need to log in before you can comment on or make changes to this bug.