WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
284079
Add a check-webkit-style to prevent merging unchanneled log (WTF_LOG_ALWAYS/WTFLogAlways)
https://bugs.webkit.org/show_bug.cgi?id=284079
Summary
Add a check-webkit-style to prevent merging unchanneled log (WTF_LOG_ALWAYS/W...
Matthieu Dubet
Reported
2024-12-04 16:48:36 PST
We regularly commit those by mistake. It should never happen.
Attachments
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2024-12-04 16:50:34 PST
WTFLogAlwas, ALWAYS_LOG_WITH_STREAM, WTF_ALWAYS_LOG Maybe fprintf({stdout, stderr}, /printf/NSLog too?
Simon Fraser (smfr)
Comment 2
2024-12-04 16:50:56 PST
^ WTFLogAlways, ALWAYS_LOG_WITH_STREAM, WTF_ALWAYS_LOG
Matthieu Dubet
Comment 3
2024-12-05 02:45:54 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37490
EWS
Comment 4
2024-12-05 11:05:46 PST
Committed
287412@main
(5ac8f6af64f9): <
https://commits.webkit.org/287412@main
> Reviewed commits have been landed. Closing PR #37490 and removing active labels.
Radar WebKit Bug Importer
Comment 5
2024-12-05 16:17:40 PST
<
rdar://problem/141013086
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug