Bug 28407 - No, silly runtime, AST nodes are not for you.
Summary: No, silly runtime, AST nodes are not for you.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-17 13:03 PDT by Gavin Barraclough
Modified: 2009-08-17 22:43 PDT (History)
1 user (show)

See Also:

Attachments
The Patch (125.57 KB, patch)
2009-08-17 13:09 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2009-08-17 13:03:12 PDT 
We still use AST nodes (ScopeNodes, particularly FunctionBodyNodes) within the runtime, which means that these nodes must be persisted outside of the arena, contain both parser & runtime data, etc.  This is all a bit of a mess.  Move functionality into a new FunctionExecutable class.
Comment 1 Gavin Barraclough 2009-08-17 13:09:49 PDT 
Created attachment 34988 [details]
The Patch
Comment 2 Gavin Barraclough 2009-08-17 22:43:28 PDT 
Transmitting file data ..........................................
Committed revision 47412.
Transmitting file data .
Committed revision 47413.
Comment 3 Gavin Barraclough 2009-08-17 22:43:40 PDT 
Transmitting file data ..........................................
Committed revision 47412.
Transmitting file data .
Committed revision 47413.