RESOLVED FIXED Bug 28406
[Qt] QtLauncher crashes on exit if the web inspector is used during the session 
https://bugs.webkit.org/show_bug.cgi?id=28406
Summary [Qt] QtLauncher crashes on exit if the web inspector is used during the session
George Wright
Reported 2009-08-17 12:37:13 PDT
If the web inspector is used during a QtLauncher session, when the program is closed it always results in a segfault: zsh: segmentation fault ./bin/QtLauncher
Attachments
patch to fix segfault (4.76 KB, patch)
2009-08-18 19:35 PDT, Benjamin Meyer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Meyer
Comment 1 2009-08-18 19:35:09 PDT
Created attachment 35099 [details] patch to fix segfault
Adam Barth
Comment 2 2009-08-26 21:55:18 PDT
Is this possible to test?
Ariya Hidayat
Comment 3 2009-09-03 01:27:49 PDT
Would it be possible to test this by creating InspectorController and watching the signal when it gets closed?
Eric Seidel (no email)
Comment 4 2009-09-03 01:35:30 PDT
Comment on attachment 35099 [details] patch to fix segfault I'm no Qt expert, but this looks sane to me.
Eric Seidel (no email)
Comment 5 2009-09-03 01:36:53 PDT
Comment on attachment 35099 [details] patch to fix segfault Hum... removing cq+ now that Qt folks are commenting here too. :) A qt committer can set it again if they're comfortable with this, or if the bug goes stale I'll set it later this week.
Eric Seidel (no email)
Comment 6 2009-09-03 06:37:19 PDT
Comment on attachment 35099 [details] patch to fix segfault Rejecting patch 35099 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Eric Seidel (no email)
Comment 7 2009-09-03 15:57:07 PDT
Comment on attachment 35099 [details] patch to fix segfault Sorry, you were yet another victim of bug 28845! It's a bad regression which is causing flakey media tests. :( media/controls-after-reload.html -> crashed
Eric Seidel (no email)
Comment 8 2009-09-03 16:03:27 PDT
Comment on attachment 35099 [details] patch to fix segfault Rejecting patch 35099 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/build-webkit failed with exit code 1
Eric Seidel (no email)
Comment 9 2009-09-03 23:59:43 PDT
Comment on attachment 35099 [details] patch to fix segfault I think the build was broken for other reasons and the bots had not yet rolled red.
Eric Seidel (no email)
Comment 10 2009-09-04 00:07:54 PDT
Comment on attachment 35099 [details] patch to fix segfault Clearing flags on attachment: 35099 Committed r48039: <http://trac.webkit.org/changeset/48039>
Eric Seidel (no email)
Comment 11 2009-09-04 00:07:58 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 12 2009-09-08 09:06:31 PDT
(In reply to comment #7) > (From update of attachment 35099 [details]) > Sorry, you were yet another victim of bug 28845! It's a bad regression which > is causing flakey media tests. :( > media/controls-after-reload.html -> crashed Actually, I was wrong, the stack trace looks different. I've filed bug 29037.
Note You need to log in before you can comment on or make changes to this bug.