Bug 28404 – [Qt] EditorClientQt::shouldShowDeleteInterface uses non-existent methods in HTMLElement

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[George Wright]

Revision 47367 removes HTMLElement::className() which is used in the shouldShowDeleteInterface() method in EditorClientQt.cpp, causing a build failure.

[George Wright]

Created attachment 34984 [details]
Return false in shouldShowDeleteInterface

Every other port simply returns false for this function, and as the method it used to call in HTMLElement has been removed, this update makes the Qt port also return false and allows it to build again.

[Eric Seidel (no email)]

Comment on attachment 34984 [details]
Return false in shouldShowDeleteInterface

OK.  I would expect the WebKit level is expected to implement this.

[Eric Seidel (no email)]

Comment on attachment 34984 [details]
Return false in shouldShowDeleteInterface

Rejecting patch 34984 from commit-queue.  This patch will require manual commit.

Patch https://bugs.webkit.org/attachment.cgi?id=34984 from bug 28404 failed to download and apply.

[Eric Seidel (no email)]

Was this already landed?
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/qt/WebCoreSupport/EditorClientQt.cpp
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file WebKit/qt/WebCoreSupport/EditorClientQt.cpp.rej
patch -p0 "WebKit/qt/WebCoreSupport/EditorClientQt.cpp" returned 1.  Pass --force to ignore patch failures.

[Adam Barth]

Please re-open if this hasn't already been landed.

[George Wright]

This patch was never landed, and the fix hasn't been applied. I can't seem to mark this bug as reopened?

[Eric Seidel (no email)]

reopening so the commit-bot will see it.

[Eric Seidel (no email)]

Except... adding it back to the commit-queue w/o modification as you have done, will just cause it to fail again, I suspect.

[WebKit Commit Bot]

Comment on attachment 34984 [details]
Return false in shouldShowDeleteInterface

Rejecting patch 34984 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebKit/qt/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/qt/WebCoreSupport/EditorClientQt.cpp
Hunk #1 FAILED at 107.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/qt/WebCoreSupport/EditorClientQt.cpp.rej

Full output: http://webkit-commit-queue.appspot.com/results/2303319

[George Wright]

Oh, I just noticed that a different fix for this bug was landed (a cursory glance at the source revealed that it looked the same, but it's actually been changed). I will re-close it.