Bug 28399 - Use OwnPtr for GraphicsLayers
Summary: Use OwnPtr for GraphicsLayers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-17 10:48 PDT by Simon Fraser (smfr)
Modified: 2009-08-17 17:42 PDT (History)
0 users

See Also:


Attachments
Patch (13.86 KB, patch)
2009-08-17 10:50 PDT, Simon Fraser (smfr)
eric: review-
Details | Formatted Diff | Diff
New patch (12.54 KB, patch)
2009-08-17 11:26 PDT, Simon Fraser (smfr)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-08-17 10:48:54 PDT
We should use OwnPtr for GraphicsLayers, to avoid the need for manual deletion.
Comment 1 Simon Fraser (smfr) 2009-08-17 10:50:22 PDT
Created attachment 34977 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-08-17 11:23:53 PDT
Comment on attachment 34977 [details]
Patch

no need for .get()->
Comment 3 Simon Fraser (smfr) 2009-08-17 11:26:32 PDT
Created attachment 34980 [details]
New patch
Comment 4 Eric Seidel (no email) 2009-08-17 11:28:02 PDT
Comment on attachment 34980 [details]
New patch

Looks good.
Comment 5 Simon Fraser (smfr) 2009-08-17 17:42:14 PDT
http://trac.webkit.org/changeset/47370