WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
283941
[WASM] Default-initialized fields of WASM GC struct should use Const32 if appropriate for storage type
https://bugs.webkit.org/show_bug.cgi?id=283941
Summary
[WASM] Default-initialized fields of WASM GC struct should use Const32 if app...
David Degazio
Reported
2024-12-02 14:16:03 PST
rdar://140773922
Currently in OMG, for struct.new_default, we either store a JSNull for reference fields, or a Const64(0) for all other fields. This makes the B3 validator unhappy if the field is an i8, i16, or i32, because for those smaller stores, it expects a Const32 value. We should emit a Const32 if appropriate to abide by the B3 type system, even if the semantics and runtime behavior are essentially identical.
Attachments
Add attachment
proposed patch, testcase, etc.
David Degazio
Comment 1
2024-12-02 14:28:23 PST
***
Bug 283888
has been marked as a duplicate of this bug. ***
David Degazio
Comment 2
2024-12-02 15:17:41 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37347
EWS
Comment 3
2024-12-03 11:17:32 PST
Committed
287295@main
(a9abb749d5da): <
https://commits.webkit.org/287295@main
> Reviewed commits have been landed. Closing PR #37347 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug