WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
283939
Add initial ImageDataArray as replacement type for ImageData::m_data, for later float16 support
https://bugs.webkit.org/show_bug.cgi?id=283939
Summary
Add initial ImageDataArray as replacement type for ImageData::m_data, for lat...
Gerald Squelart
Reported
2024-12-02 13:53:18 PST
Currently `ImageData::m_data` is a `Ref<JSC::Uint8ClampedArray>` (corresponding to ImageData.idl's `attribute ImageDataArray data`), so it can only deal with byte-sized color components like RGBA. To allow float16 support (the idl data type will change to something like `typedef (Uint8ClampedArray or Float16Array) ImageDataArray`), `ImageData::m_data` should be able to hold other typed-array types, like `JSC::Float16Array`. As a first step, we'll move the `Ref<JSC::Uint8ClampedArray>` to a separate class, and that class will eventually handle more types.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-12-02 13:53:27 PST
<
rdar://problem/140813668
>
Gerald Squelart
Comment 2
2024-12-02 13:57:35 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37344
Gerald Squelart
Comment 3
2024-12-02 14:03:51 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37239
Gerald Squelart
Comment 4
2024-12-03 14:59:52 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37121
EWS
Comment 5
2024-12-03 15:27:06 PST
Committed
287312@main
(faf054788cd8): <
https://commits.webkit.org/287312@main
> Reviewed commits have been landed. Closing PR #37344 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug