Bug 28390 - WebInspector: Reset InjectedScript styles cache on document change.
Summary: WebInspector: Reset InjectedScript styles cache on document change.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-17 08:07 PDT by Pavel Feldman
Modified: 2009-08-17 10:44 PDT (History)
1 user (show)

See Also:


Attachments
patch (5.46 KB, patch)
2009-08-17 08:08 PDT, Pavel Feldman
timothy: review-
Details | Formatted Diff | Diff
patch (6.42 KB, patch)
2009-08-17 10:31 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-08-17 08:07:23 PDT
Reset InjectedScript styles cache on document change.
Comment 1 Pavel Feldman 2009-08-17 08:08:41 PDT
Created attachment 34968 [details]
patch
Comment 2 Timothy Hatcher 2009-08-17 09:33:13 PDT
Comment on attachment 34968 [details]
patch

_reset should be reset since it isn't private.
Comment 3 Pavel Feldman 2009-08-17 09:49:16 PDT
(In reply to comment #2)
> (From update of attachment 34968 [details])
> _reset should be reset since it isn't private.

The reason I made is private was that I wanted to show that it is called _not_ from the frontend, but from the InspectorController host itself (as with _createProxyObject). But I can highlight that in comments if you'd like.
Comment 4 Timothy Hatcher 2009-08-17 09:52:24 PDT
I think a comment and dropping the underscore would be best (in the case of _createProxyObject too). Anything called from another file should not have a underscore.
Comment 5 Pavel Feldman 2009-08-17 10:31:26 PDT
Created attachment 34976 [details]
patch

Thanks for review.

Fixed the underscores!
Comment 6 Pavel Feldman 2009-08-17 10:44:12 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/InspectorDOMAgent.h
	M	WebCore/inspector/front-end/InjectedScript.js
Committed r47369