WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
283764
[Tools][GTK][WPE] generate-bundle test suite: retry tests before marking them as a failure to avoid flaky/random/network issues
https://bugs.webkit.org/show_bug.cgi?id=283764
Summary
[Tools][GTK][WPE] generate-bundle test suite: retry tests before marking them...
Carlos Alberto Lopez Perez
Reported
2024-11-27 08:52:46 PST
On the nightly packaging bots we run a test step with webdriver and the bundle to ensure that it works as expected. The problem is that this is step is randomly failing. I suspect is related with the network as some tests require loading resources from internet (videos, ssl certs, wasm files, etc) So to make the test step more robust retry each one of the webdriver tests up to 3 times (by default) before marking it as a failure. This should not be an issue if the generated bundle is broken as in that case it should fail the 3 times and that is what we are looking to detect with this test suite.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2024-11-27 08:58:49 PST
Examples:
https://build.webkit.org/#/builders/1321/builds/46
https://build.webkit.org/#/builders/1322/builds/46
https://build.webkit.org/#/builders/1322/builds/45
Carlos Alberto Lopez Perez
Comment 2
2024-11-27 09:01:58 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37201
EWS
Comment 3
2024-11-28 04:59:29 PST
Committed
287150@main
(28de6f13360b): <
https://commits.webkit.org/287150@main
> Reviewed commits have been landed. Closing PR #37201 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2024-11-28 05:00:15 PST
<
rdar://problem/140657628
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug