Bug 28376 - [Cleanup] isAfterContent() implemented twice, should be member of RenderObject
Summary: [Cleanup] isAfterContent() implemented twice, should be member of RenderObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Trivial
Assignee: Nobody
URL:
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2009-08-16 22:05 PDT by Roland Steiner
Modified: 2009-08-17 17:58 PDT (History)
1 user (show)

See Also:


Attachments
[patch] move implementation of isAfterContent to RenderObject (3.90 KB, patch)
2009-08-16 22:09 PDT, Roland Steiner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2009-08-16 22:05:07 PDT
The function isAfterContent() is implemented twice, once in RenderInline as a static function, once in RenderBox.
Both implementations are equal. 

Also, there is nothing in the implementation that would prevent having this functionality available as a member on RenderObject.
Comment 1 Roland Steiner 2009-08-16 22:09:37 PDT
Created attachment 34949 [details]
[patch] move implementation of isAfterContent to RenderObject

Moved implementation of isAfterContent to RenderObject, remove from RenderBox and RenderInline.

All layout tests passed.
Comment 2 Eric Seidel (no email) 2009-08-17 17:13:52 PDT
Comment on attachment 34949 [details]
[patch] move implementation of isAfterContent to RenderObject

LGTM.
Comment 3 Eric Seidel (no email) 2009-08-17 17:58:17 PDT
Comment on attachment 34949 [details]
[patch] move implementation of isAfterContent to RenderObject

Clearing flags on attachment: 34949

Committed r47403: <http://trac.webkit.org/changeset/47403>
Comment 4 Eric Seidel (no email) 2009-08-17 17:58:21 PDT
All reviewed patches have been landed.  Closing bug.