WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
283655
TestWTF.WTF_URLParser.ParserDifferences fails with ICU 76.1
https://bugs.webkit.org/show_bug.cgi?id=283655
Summary
TestWTF.WTF_URLParser.ParserDifferences fails with ICU 76.1
Fujii Hironori
Reported
2024-11-24 13:23:02 PST
After WebKitRequirements v2024.10.25 bumpped ICU from 75.1 to 76.1, two url tests fail.
https://github.com/WebKitForWindows/WebKitRequirements/releases/tag/v2024.10.25
Buildbot: builder Windows-64-bit-Release-Tests build 896 :
285774@main
https://build.webkit.org/#/builders/1191/builds/896
TestWTF.WTF_URLParser.ParserDifferences C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "" s2.utf8().data() Which is: "http" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:151 Value of: eq(parts.protocol, url.protocol()) Actual: false Expected: true C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "" s2.utf8().data() Which is: "xn--73g" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:154 Value of: eq(parts.host, url.host()) Actual: false Expected: true C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "" s2.utf8().data() Which is: "/" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:156 Value of: eq(parts.path, url.path()) Actual: false Expected: true C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "
http://\xE2\x84\xB2
" As Text: "
http://\u2132
" s2.utf8().data() Which is: "
http://xn--73g/
" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:159 Value of: eq(parts.string, url.string()) Actual: false Expected: true C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "" s2.utf8().data() Which is: "http" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:151 Value of: eq(parts.protocol, url.protocol()) Actual: false Expected: true C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "" s2.utf8().data() Which is: "xn--73g" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:154 Value of: eq(parts.host, url.host()) Actual: false Expected: true C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "" s2.utf8().data() Which is: "/" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:156 Value of: eq(parts.path, url.path()) Actual: false Expected: true C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "\thttp://\xE2\x84\xB2" As Text: "
http://\u2132
" s2.utf8().data() Which is: "
http://xn--73g/
" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:159 Value of: eq(parts.string, url.string()) Actual: false Expected: true C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "" s2.utf8().data() Which is: "http" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:151 Value of: eq(parts.protocol, url.protocol()) Actual: false Expected: true C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "" s2.utf8().data() Which is: "xn--73g" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:154 Value of: eq(parts.host, url.host()) Actual: false Expected: true C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:71 Expected equality of these values: s1.utf8().data() Which is: "" s2.utf8().data() Which is: "/" C:\BW\Windows-64-bit-Release-Build\build\Tools\TestWebKitAPI\Tests\WTF\URLParser.cpp:
Attachments
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2024-11-24 13:42:02 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37104
Fujii Hironori
Comment 2
2024-11-24 13:48:44 PST
ICU 76 supports Unicode 16.
https://unicode-org.github.io/icu/download/76.html
Unicode 16.0.0 contains IDNA changes.
https://www.unicode.org/versions/Unicode16.0.0/
EWS
Comment 3
2024-12-01 03:54:09 PST
Committed
287189@main
(8c1b94022359): <
https://commits.webkit.org/287189@main
> Reviewed commits have been landed. Closing PR #37104 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2024-12-01 03:55:13 PST
<
rdar://problem/140746411
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug