RESOLVED FIXED 283626
VideoMediaSampleRenderer drops more frames than it should. 
https://bugs.webkit.org/show_bug.cgi?id=283626
Summary VideoMediaSampleRenderer drops more frames than it should.
Jean-Yves Avenard [:jya]
Reported 2024-11-23 05:22:26 PST
Following bug 283259, we can easily see the dropped frame count. And it is higher than it should be.. On a beefy Mac Studio M2 Ultra 24 cores, the frame dropped rate is about 0.5% Similar to bug 283275, we see frames being dropped due to a difference in timescale. Current Time is using a 10ns timescale currentTime CMTime 17150040124 1000000000ths of a second while the sample is using a millisecond timescale presentationEndTime CMTime 17150 1000ths of a second So it is dropped. But really, it's close enough and it shouldn't be
Attachments
Add attachment proposed patch, testcase, etc.
Jean-Yves Avenard [:jya]
Comment 1 2024-11-24 04:50:40 PST
Analysis above on why frames were dropped was incorrect. Incoming fix.
Jean-Yves Avenard [:jya]
Comment 2 2024-11-24 16:31:08 PST
rdar://140515014
Jean-Yves Avenard [:jya]
Comment 3 2024-11-24 16:50:31 PST
Pull request: https://github.com/WebKit/WebKit/pull/37107
EWS
Comment 4 2024-11-25 14:12:16 PST
Committed 287074@main (88039a970adb): <https://commits.webkit.org/287074@main> Reviewed commits have been landed. Closing PR #37107 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.