RESOLVED FIXED 283621
Repaint not triggered when only text-underline-offset changes
https://bugs.webkit.org/show_bug.cgi?id=283621
Summary Repaint not triggered when only text-underline-offset changes
s7tya
Reported 2024-11-22 22:33:10 PST
# Step to reproduce 1) Go to https://jsfiddle.net/6t73Lekh/ (or use the code provided below) 2) Hover your cursor over the links. ```html <style> a { text-decoration: underline; text-decoration-skip-ink: none; &:hover { text-underline-offset: -5px; } } #ok:hover { color: orange; } </style> <a href="https://example.com" id="ok">OK</div> <a href="https://example.com" id="ng">NG</div> ``` Expected Results: A repaint should be triggered, and the underline should move up to the middle of the link when hovering. Actual Results: The repaint does not occur, and the underline remains in its original position for now. # Potential Cause: This issue might be due to a missing comparison in the `RenderStyle::changeRequiresRepaintIfText`. Specifically, we should check: `m_rareInheritedData->textUnderlineOffset != other.m_rareInheritedData->textUnderlineOffset`. https://github.com/mdubet/WebKit/blob/4a51bf6f3d5146526cc00c18289073f512e40637/Source/WebCore/rendering/style/RenderStyle.cpp#L1345-L1354
Attachments
s7tya
Comment 2 2024-11-23 00:51:05 PST
EWS
Comment 3 2024-11-24 17:58:18 PST
Committed 287048@main (958c0c8b47a0): <https://commits.webkit.org/287048@main> Reviewed commits have been landed. Closing PR #37074 and removing active labels.
Radar WebKit Bug Importer
Comment 4 2024-11-24 17:59:14 PST
Note You need to log in before you can comment on or make changes to this bug.