WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
283590
ComputedStyleExtractor should check renderers for margin values
https://bugs.webkit.org/show_bug.cgi?id=283590
Summary
ComputedStyleExtractor should check renderers for margin values
Sammy Gill
Reported
2024-11-22 14:01:37 PST
If we have a valid renderer, then we should just check it for the used margin values since we already store them there. Even if the value is fixed we need to check the renderer because certain properties can result in the used value being different (e.g. margin-trim or block-step-size)
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-11-22 14:02:08 PST
<
rdar://problem/140439313
>
Sammy Gill
Comment 2
2024-11-22 14:22:19 PST
Pull request:
https://github.com/WebKit/WebKit/pull/37048
EWS
Comment 3
2024-12-01 14:54:09 PST
Committed
287196@main
(5a0b0f236dce): <
https://commits.webkit.org/287196@main
> Reviewed commits have been landed. Closing PR #37048 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug