Bug 28356 - WebInspector: A handful of DOMAgent-related fixes and cleanups.
Summary: WebInspector: A handful of DOMAgent-related fixes and cleanups.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2009-08-16 06:55 PDT by Pavel Feldman
Modified: 2009-08-16 09:16 PDT (History)
1 user (show)

See Also:

patch (52.08 KB, patch)
2009-08-16 06:57 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-08-16 06:55:46 PDT
- renamed elementId to nodeId in operations on nodes.
- added load listeners to frame owners in InspectorDOMAgent.
- removed InspectorController::inspectedWindowScriptObjectCleared event.
- preserved isViaInspector flag for 'via inspector' marker to survive styles update.
- removed contentDocument-related logic from ElementsPanel since it is handled in the InspectorDOMAgent.
- removed DOM listeners unregistration and corresponding events from InspectorController.
- made this.styles 'private' in ElementsPanel.
- added TODO for the remote handleCopy processing in ElementsPanel.
Comment 1 Pavel Feldman 2009-08-16 06:57:29 PDT
Created attachment 34926 [details]
Comment 2 Timothy Hatcher 2009-08-16 08:23:57 PDT
Comment on attachment 34926 [details]

> +                // TODO: Introduce InspectorController.copyEvent that pushes appropriate markup into the clipboard.

Can you write a new bug about this?
Comment 3 Pavel Feldman 2009-08-16 09:16:13 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.order
	M	WebCore/inspector/InspectorBackend.cpp
	M	WebCore/inspector/InspectorBackend.h
	M	WebCore/inspector/InspectorBackend.idl
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/InspectorDOMAgent.h
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/InspectorFrontend.h
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/ElementsPanel.js
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/StylesSidebarPane.js
	M	WebCore/inspector/front-end/inspector.js
	M	WebCore/inspector/front-end/treeoutline.js
	M	WebCore/inspector/front-end/utilities.js
	M	WebCore/loader/FrameLoader.cpp
	M	WebCore/page/android/InspectorControllerAndroid.cpp
Committed r47339