RESOLVED FIXED Bug 28356
WebInspector: A handful of DOMAgent-related fixes and cleanups.
https://bugs.webkit.org/show_bug.cgi?id=28356
Summary WebInspector: A handful of DOMAgent-related fixes and cleanups.
Pavel Feldman
Reported 2009-08-16 06:55:46 PDT
- renamed elementId to nodeId in operations on nodes. - added load listeners to frame owners in InspectorDOMAgent. - removed InspectorController::inspectedWindowScriptObjectCleared event. - preserved isViaInspector flag for 'via inspector' marker to survive styles update. - removed contentDocument-related logic from ElementsPanel since it is handled in the InspectorDOMAgent. - removed DOM listeners unregistration and corresponding events from InspectorController. - made this.styles 'private' in ElementsPanel. - added TODO for the remote handleCopy processing in ElementsPanel.
Attachments
patch (52.08 KB, patch)
2009-08-16 06:57 PDT, Pavel Feldman
timothy: review+
Pavel Feldman
Comment 1 2009-08-16 06:57:29 PDT
Timothy Hatcher
Comment 2 2009-08-16 08:23:57 PDT
Comment on attachment 34926 [details] patch > + // TODO: Introduce InspectorController.copyEvent that pushes appropriate markup into the clipboard. Can you write a new bug about this?
Pavel Feldman
Comment 3 2009-08-16 09:16:13 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.order M WebCore/inspector/InspectorBackend.cpp M WebCore/inspector/InspectorBackend.h M WebCore/inspector/InspectorBackend.idl M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h M WebCore/inspector/InspectorDOMAgent.cpp M WebCore/inspector/InspectorDOMAgent.h M WebCore/inspector/InspectorFrontend.cpp M WebCore/inspector/InspectorFrontend.h M WebCore/inspector/front-end/DOMAgent.js M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/ElementsTreeOutline.js M WebCore/inspector/front-end/InjectedScript.js M WebCore/inspector/front-end/StylesSidebarPane.js M WebCore/inspector/front-end/inspector.js M WebCore/inspector/front-end/treeoutline.js M WebCore/inspector/front-end/utilities.js M WebCore/loader/FrameLoader.cpp M WebCore/page/android/InspectorControllerAndroid.cpp Committed r47339
Note You need to log in before you can comment on or make changes to this bug.