RESOLVED FIXED 283507
Pack CSS::PrimitiveNumeric 
https://bugs.webkit.org/show_bug.cgi?id=283507
Summary Pack CSS::PrimitiveNumeric
Sam Weinig
Reported 2024-11-21 11:32:50 PST
Pack CSS::PrimitiveNumeric by replacing std::variant with a union, and using the CSSUnitType to determine the correct alternative. An alternative we may want to explore in the future when we no longer have the old CSSValue system around is creating a type per unit (e.g. Px { double value; }; Em { double value; }; ...) and using a std::variant with them, but since we still need to utilize CSSUnitTypes for the moment, that would be less efficient.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2024-11-21 11:56:21 PST
Pull request: https://github.com/WebKit/WebKit/pull/36966
EWS
Comment 2 2024-11-22 12:49:49 PST
Committed 286978@main (2ba07c2f90a7): <https://commits.webkit.org/286978@main> Reviewed commits have been landed. Closing PR #36966 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-11-22 12:50:15 PST
<rdar://problem/140435621>
Note You need to log in before you can comment on or make changes to this bug.