WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
283454
Get GraphicsLayer.h out of some hot include paths
https://bugs.webkit.org/show_bug.cgi?id=283454
Summary
Get GraphicsLayer.h out of some hot include paths
Simon Fraser (smfr)
Reported
2024-11-20 18:28:52 PST
Helping with the speed of the build.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-11-20 18:29:10 PST
<
rdar://problem/140314709
>
Simon Fraser (smfr)
Comment 2
2024-11-20 18:30:47 PST
783882 ms: /Volumes/Data/Development/system/webkit/OpenSource/Source/WebCore/platform/graphics/GraphicsLayer.h (included 408 times, avg 1921 ms), included via: 47x: DocumentInlines.h LocalDOMWindow.h DOMWindow.h ImageBitmap.h ImageBuffer.h ImageBufferBackend.h GraphicsLayerContentsDisplayDelegate.h 36x: GraphicsContext.h GraphicsContextState.h SourceBrush.h Pattern.h SourceImage.h ImageBuffer.h ImageBufferBackend.h GraphicsLayerContentsDisplayDelegate.h 27x: ElementInlines.h DocumentInlines.h LocalDOMWindow.h DOMWindow.h ImageBitmap.h ImageBuffer.h ImageBufferBackend.h GraphicsLayerContentsDisplayDelegate.h 19x: ChromeClient.h GraphicsContext.h GraphicsContextState.h SourceBrush.h Pattern.h SourceImage.h ImageBuffer.h ImageBufferBackend.h GraphicsLayerContentsDisplayDelegate.h 16x: Editor.h FrameSelection.h CaretAnimator.h RenderTheme.h GraphicsContext.h GraphicsContextState.h SourceBrush.h Pattern.h SourceImage.h ImageBuffer.h ImageBufferBackend.h GraphicsLayerContentsDisplayDelegate.h 15x: LocalDOMWindow.h DOMWindow.h ImageBitmap.h ImageBuffer.h ImageBufferBackend.h GraphicsLayerContentsDisplayDelegate.h ...
Simon Fraser (smfr)
Comment 3
2024-11-20 18:40:00 PST
Pull request:
https://github.com/WebKit/WebKit/pull/36929
EWS
Comment 4
2024-11-21 08:48:19 PST
Committed
286910@main
(af0b4e780f10): <
https://commits.webkit.org/286910@main
> Reviewed commits have been landed. Closing PR #36929 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug