Bug 28340 - 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped
Summary: 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-15 11:43 PDT by Simon Fraser (smfr)
Modified: 2009-08-24 13:05 PDT (History)
4 users (show)

See Also:


Attachments
Testcase (4.94 KB, application/octet-stream)
2009-08-15 11:43 PDT, Simon Fraser (smfr)
no flags Details
Simpler testcase (136 bytes, text/html)
2009-08-17 23:16 PDT, Simon Fraser (smfr)
no flags Details
MiniBrowser 64-bit (175.83 KB, image/png)
2009-08-24 05:10 PDT, Pavel Feldman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-08-15 11:43:10 PDT
Created attachment 34902 [details]
Testcase

I get that assertion with the attached testcase, when the inspector is open.
Comment 1 Simon Fraser (smfr) 2009-08-17 16:58:40 PDT
This is preventing me from getting work done.
Comment 2 Sam Weinig 2009-08-17 20:16:08 PDT
Simon, do you know when this regressed?
Comment 3 Simon Fraser (smfr) 2009-08-17 20:22:51 PDT
I think I first saw it on Saturday.
Comment 4 Pavel Feldman 2009-08-17 21:56:25 PDT
I is likely to be caused by the DOMAgent migration in the WebInspector. Will fix it shortly.
Comment 5 Pavel Feldman 2009-08-17 22:34:24 PDT
The assertion reported is clearly WebInspector's fault, but I can't repro it on ToT. It behaves exactly as in Safari 4.0.2. Here is what I do:

1. Open sample attached
2. Open WebInspector
3. Refresh the page

I see 6 entries in the console:
1. > [CSSValue] transition-test-helpers.js:72
2. TypeError: Result of expression 'computedStyle[i].getFloatValue' [undefined] is not a function. transition-test-helpers.js:73
3. > [CSSValue] transition-test-helpers.js:72
4. TypeError: Result of expression 'computedStyle[i].getFloatValue' [undefined] is not a function. transition-test-helpers.js:73
5. > [CSSValue] transition-test-helpers.js:72
6. TypeError: Result of expression 'computedStyle[i].getFloatValue' [undefined] is not a function. transition-test-helpers.js:73

The reason of errors is that the style value is instanceof CSSValue, not CSPrimitiveValue. If I put a check there before calling, I am getting the test PASSED.

Are you sure we are not talking about some local modifications you have? They could uncover the bug.
Comment 6 Simon Fraser (smfr) 2009-08-17 23:16:05 PDT
Created attachment 35019 [details]
Simpler testcase
Comment 7 Oliver Hunt 2009-08-22 23:26:38 PDT
An even simpler way to repro:
1. open the console
2. Math.sin

assertion failure
Comment 8 Pavel Feldman 2009-08-23 01:57:35 PDT
Both scenarios work fine on 32-bit and on Chromium 64-bit. Latter uses another version of DOM bindings including different quarantine code though. So most likely the problem is with the JSC quarantines.

I don't feel comfortable owning this bug since I can't reproduce it in the standard WebKit environment. Note that I am working on removing quarantines from the Web Inspector at all, so that the bug might become obsolete some time soon.
Comment 9 Simon Fraser (smfr) 2009-08-23 09:26:47 PDT
We need to figure out when this regressed.
Comment 10 Pavel Feldman 2009-08-23 13:08:44 PDT
(In reply to comment #9)
> We need to figure out when this regressed.

It is known when it regressed (my Migrate to DOMAgent change), but it is unclear why it is only triggering on 64bit. I can't reproduce it, but I know that it is triggering in the console formatting code. I hope Oliver finishes his analysis and points me to the statement in the javascript code triggering the assertion.
Comment 11 Pavel Feldman 2009-08-24 05:10:35 PDT
Created attachment 38477 [details]
MiniBrowser 64-bit
Comment 12 Pavel Feldman 2009-08-24 05:24:35 PDT
(In reply to comment #11)
> Created an attachment (id=38477) [details]
> MiniBrowser 64-bit

I see no problems running MiniBrowser 64-bit. All test cases behave as in Safari 4, I see no assertions triggered. See screenshot attached.
Comment 13 Simon Fraser (smfr) 2009-08-24 13:05:10 PDT
I can no longer reproduce the issue.