Bug 28337 - Fix build for ports which don't enable JIT.
Summary: Fix build for ports which don't enable JIT.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P1 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-15 01:29 PDT by Maxime Simon
Modified: 2009-08-17 22:04 PDT (History)
0 users

See Also:

Attachments
Patch v1 (1.19 KB, patch)
2009-08-15 01:32 PDT, Maxime Simon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Simon 2009-08-15 01:29:20 PDT 
In changeset 47304 a new header were introduced, Executable.h.
When compiling a port which doesn't support JIT it fails on this header because the JITCode& jitCode() function isn't surrounded by "#if ENABLE(JIT) … #endif".

Maxime
Comment 1 Maxime Simon 2009-08-15 01:32:59 PDT 
Created attachment 34893 [details]
Patch v1
Comment 2 Maxime Simon 2009-08-16 00:15:23 PDT 
Bug also seen on Leopard PPC.
Comment 3 Maxime Simon 2009-08-17 03:21:27 PDT 
Corrected at r47330
Comment 4 Eric Seidel (no email) 2009-08-17 17:11:07 PDT 
Comment on attachment 34893 [details]
Patch v1

A similar patch was landed as http://trac.webkit.org/changeset/47330.  No need for this to be in the review queue anymore. :)
Comment 5 Maxime Simon 2009-08-17 22:04:02 PDT 
(In reply to comment #4)
> (From update of attachment 34893 [details])
> A similar patch was landed as http://trac.webkit.org/changeset/47330.  No need
> for this to be in the review queue anymore. :)

Indeed, but like the bug 28339 which also received a fix before being reviewed, I marked this one as closed. But I should also tag as obsolete the patches, that's not automatique. ;)