Bug 28336 – Can no longer --reset-results of a layout test directory

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dave Hyatt]

I get error spew when  I try to reset results of a directory.... commenting out lines 997-1002 in run-webkit-tests fixes the issue.

[Mark Rowe (bdash)]

Seems like this could happen if the first test that is run happens to fail?

[Eric Seidel (no email)]

I'll investigate on Monday.  Away for the weekend.  You're welcome to roll out the change if needed.

[Eric Seidel (no email)]

Created attachment 34990 [details]
Patch v1

[Eric Seidel (no email)]

The problem was that I had assumed all modes of run-webkit-tests used the %counts dictionary.  It turns out %counts is not used when --reset-results is true.  I've fixed the code to ignore --exit-after-n-failures in the case of --reset-results.

Sorry for the trouble Dave.

[Mark Rowe (bdash)]

The code still seems as though it will not do the right thing if $counts{match} is undefined.  At the least it will emit a diagnostic.  As I mentioned in an earlier comment, this look as though it could happen if the first tests fails.  Am I missing something?

[Eric Seidel (no email)]

You are correct it happens when the first test fails too.

foo.html -> new (results generated in /Users/eseidel/Projects/WebKit2/LayoutTests/platform/mac)
Use of uninitialized value in subtraction (-) at WebKitTools/Scripts/run-webkit-tests line 999.

Exiting early after 1 failures.  1 tests run.

I'll update the patch.

[Eric Seidel (no email)]

Created attachment 34991 [details]
Updated to fix first-test failure case too

[Eric Seidel (no email)]

Thanks for the catch.  I've updated the patch to handle the case where the first test fails as well.

[Eric Seidel (no email)]

Comment on attachment 34991 [details]
Updated to fix first-test failure case too

Clearing flags on attachment: 34991

Committed r47402: <http://trac.webkit.org/changeset/47402>

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.