RESOLVED FIXED283302
Text content inside `content-visibility: hidden` inline container should show up in `innerText` 
https://bugs.webkit.org/show_bug.cgi?id=283302
Summary Text content inside `content-visibility: hidden` inline container should show...
Attachments
Testcase (678 bytes, text/html)
2024-11-18 09:39 PST, Tim Nguyen (:ntim) 		no flags
Details
Patch (1.16 KB, patch)
2024-11-19 20:43 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.67 KB, patch)
2024-11-20 08:28 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.67 KB, patch)
2024-11-20 09:49 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.79 KB, patch)
2024-11-21 17:02 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (5.79 KB, patch)
2024-11-22 13:54 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (14.80 KB, patch)
2024-11-22 20:24 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2024-11-18 09:39:57 PST
Created attachment 473267 [details] Testcase
alan
Comment 2 2024-11-19 20:43:34 PST
Created attachment 473287 [details] Patch
alan
Comment 3 2024-11-20 08:28:52 PST
Created attachment 473296 [details] Patch
alan
Comment 4 2024-11-20 08:32:31 PST
(In reply to Tim Nguyen (:ntim) from comment #0) > I suspect this line is wrong: > https://searchfox.org/wubkat/rev/d45649fa32a499702c30474e94bd6843c4c67849/ > Source/WebCore/editing/TextIterator.cpp#489-490 This line is correct. The issue here is that isSkippedContentRoot() lies in non-atomic inline level case.
alan
Comment 5 2024-11-20 09:49:53 PST
Created attachment 473297 [details] Patch
alan
Comment 6 2024-11-20 19:43:16 PST
Apparently this requires another hack in RenderObject::isSkippedContent...because StyleAdjuster can't figure out if an element can have content-visibility (the non-atomic inline level element part)...and instead of piling up hacks, let's fix the root cause (i.e. being able to figure out whether an element is replaced on not).
alan
Comment 7 2024-11-21 17:02:18 PST
Created attachment 473324 [details] Patch
alan
Comment 8 2024-11-22 13:54:43 PST
Created attachment 473345 [details] Patch
alan
Comment 9 2024-11-22 20:24:37 PST
Created attachment 473353 [details] [fast-cq]Patch
EWS
Comment 10 2024-11-23 05:12:17 PST
Committed 287008@main (e0c06d5dc8f5): <https://commits.webkit.org/287008@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 473353 [details].
Radar WebKit Bug Importer
Comment 11 2024-11-23 05:13:55 PST
<rdar://problem/140467885>
Tim Nguyen (:ntim)
Comment 12 2024-11-24 17:42:08 PST
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/49346
Note You need to log in before you can comment on or make changes to this bug.