Bug 28330 - Remove AST nodes from use within the Runtime (outside of parsing), stage 1
Summary: Remove AST nodes from use within the Runtime (outside of parsing), stage 1
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-08-14 16:21 PDT by Gavin Barraclough
Modified: 2009-08-14 18:42 PDT (History)
0 users

See Also:

The Patch (42.23 KB, patch)
2009-08-14 17:00 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2009-08-14 16:21:45 PDT
Remove the EvalNode and ProgramNode from use in the runtime.  They still exist after this patch, but are hidden behind EvalExecutable and FunctionExecutable, and are also still reachable behind CodeBlock::m_ownerNode.
The next step will be to beat back FunctionBodyNode in the same fashion.
Then remove the usage via CodeBlock, then only construct these nodes only on demand during bytecode generation.
Comment 1 Gavin Barraclough 2009-08-14 17:00:10 PDT
Created attachment 34881 [details]
The Patch
Comment 2 Oliver Hunt 2009-08-14 17:07:50 PDT
Comment on attachment 34881 [details]
The Patch

Comment 3 Gavin Barraclough 2009-08-14 18:42:09 PDT
fixed in