WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
28330
Remove AST nodes from use within the Runtime (outside of parsing), stage 1
https://bugs.webkit.org/show_bug.cgi?id=28330
Summary
Remove AST nodes from use within the Runtime (outside of parsing), stage 1
Gavin Barraclough
Reported
2009-08-14 16:21:45 PDT
Remove the EvalNode and ProgramNode from use in the runtime. They still exist after this patch, but are hidden behind EvalExecutable and FunctionExecutable, and are also still reachable behind CodeBlock::m_ownerNode. The next step will be to beat back FunctionBodyNode in the same fashion. Then remove the usage via CodeBlock, then only construct these nodes only on demand during bytecode generation.
Attachments
The Patch
(42.23 KB, patch)
2009-08-14 17:00 PDT
,
Gavin Barraclough
oliver
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2009-08-14 17:00:10 PDT
Created
attachment 34881
[details]
The Patch
Oliver Hunt
Comment 2
2009-08-14 17:07:50 PDT
Comment on
attachment 34881
[details]
The Patch r=me!
Gavin Barraclough
Comment 3
2009-08-14 18:42:09 PDT
fixed in
http://trac.webkit.org/changeset/47304
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug