Bug 28326 - DRT on Windows doesn't support LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota
Summary: DRT on Windows doesn't support LayoutTestController::setQuota or print a call...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-14 15:30 PDT by Brian Weinstein
Modified: 2009-08-19 16:42 PDT (History)
0 users

See Also:

Attachments
Fix (11.49 KB, patch)
2009-08-17 11:12 PDT, Brian Weinstein 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2009-08-14 15:30:14 PDT 
DRT on Windows doesn't support LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
Comment 1 Brian Weinstein 2009-08-17 11:12:37 PDT 
Created attachment 34978 [details]
Fix
Comment 2 Eric Seidel (no email) 2009-08-17 17:21:21 PDT 
Comment on attachment 34978 [details]
Fix

I'm confused by this code:
     COMPtr<IWebDatabaseManager> databaseManager;
 731     COMPtr<IWebDatabaseManager> tmpDatabaseManager;
 732 
 733     if (FAILED(WebKitCreateInstance(CLSID_WebDatabaseManager, 0, IID_IWebDatabaseManager, (void**)&tmpDatabaseManager)))
 734         return;
 735     if (FAILED(tmpDatabaseManager->sharedWebDatabaseManager(&databaseManager)))
 736         return;

Maybe it could be explained in a comment or the ChangeLgo why you need two IWebDatabaseManager pointers there?
Comment 3 Brian Weinstein 2009-08-17 17:22:25 PDT 
I got that code from a different function in the same file that used the same way of getting the real database manager. I can do a little legwork there and figure out why it's doing that though.
Comment 4 Brian Weinstein 2009-08-19 16:42:53 PDT 
Committed in http://trac.webkit.org/changeset/47447