RESOLVED FIXED283253
Refactor webkitscmpy.program.canonicalize.message to be more testable 
https://bugs.webkit.org/show_bug.cgi?id=283253
Summary Refactor webkitscmpy.program.canonicalize.message to be more testable
Sam Sneddon [:gsnedders]
Reported 2024-11-16 20:16:41 PST
Currently it's a singular, big main function. We should split it up to call into a smaller `rewrite_message` which can be tested in isolation. https://github.com/WebKit/WebKit/pull/36498 added a lot of tests here, but it does so in the same way as the existing tests: with a huge amount of setup, relying on our git mock, rather than testing the unit we actually care about here: how we rewrite the message.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2024-11-16 20:40:24 PST
Pull request: https://github.com/WebKit/WebKit/pull/36768
Radar WebKit Bug Importer
Comment 2 2024-11-23 20:17:13 PST
<rdar://problem/140487902>
EWS
Comment 3 2024-12-03 11:36:44 PST
Committed 287298@main (d07c38a4698e): <https://commits.webkit.org/287298@main> Reviewed commits have been landed. Closing PR #36768 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.