RESOLVED FIXED283239
[Cleanup][Floats] Move FloatingContext's top/bottom methods to PlacedFloats 
https://bugs.webkit.org/show_bug.cgi?id=283239
Summary [Cleanup][Floats] Move FloatingContext's top/bottom methods to PlacedFloats
alan
Reported 2024-11-16 15:43:25 PST
ssia
Attachments
Patch (11.05 KB, patch)
2024-11-16 15:54 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (11.05 KB, patch)
2024-11-18 05:30 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq]Patch (11.05 KB, patch)
2024-11-18 05:58 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-11-16 15:54:51 PST
Created attachment 473243 [details] Patch
Antti Koivisto
Comment 2 2024-11-18 03:59:18 PST
Comment on attachment 473243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=473243&action=review > Source/WebCore/layout/floats/PlacedFloats.cpp:132 > +std::optional<LayoutUnit> PlacedFloats::topMost() const topmost()/bottommost()? I think it is a single word so no capitalization in the middle.
alan
Comment 3 2024-11-18 05:30:26 PST
Created attachment 473259 [details] Patch
alan
Comment 4 2024-11-18 05:58:41 PST
Created attachment 473261 [details] [fast-cq]Patch
EWS
Comment 5 2024-11-18 07:19:11 PST
Committed 286723@main (81e7db38bc4a): <https://commits.webkit.org/286723@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 473261 [details].
Radar WebKit Bug Importer
Comment 6 2024-11-18 07:20:15 PST
<rdar://problem/140121125>
Note You need to log in before you can comment on or make changes to this bug.